[None][infra] Waive 2 failed cases for main in post-merge 2741 - #14737
Conversation
Bug(s): 6236094, 6240561 Requested by: @EmmaQiaoCh Signed-off-by: ZhanruiSunCh <184402041+ZhanruiSunCh@users.noreply.github.com>
|
/bot run |
📝 WalkthroughWalkthroughThis PR adds two entries to the integration test waiver list, marking test cases as ChangesTest Waivers
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/test_lists/waives.txt (1)
17-17: QA Assessment: Test coverage impact is acceptable with proper tracking.From a QA perspective, this PR waives two test cases with proper bug references:
- Accuracy test (line 17): Model registry autodeploy for DeepSeek-R1-0528 - tracked in nvbugs/6240561
- Performance test (line 280): E2E sanity for k25_thinking_fp4_blackwell configuration - tracked in nvbugs/6236094
Coverage assessment: Temporarily insufficient for the specific configurations above, but acceptable given:
- Both failures are tracked in NVBugs with clear references
- Auto-generated waive process ensures visibility
- Follow-up should occur through the bug tracking system
Recommendation: Ensure the linked bugs (6236094, 6240561) have active owners and timelines for resolution to restore full test coverage. Based on learnings, the short nvbug URL format is correctly used throughout.
Also applies to: 280-280
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/integration/test_lists/waives.txt` at line 17, The waive entries for the two skipped tests (accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry[deepseek-ai_DeepSeek-R1-0528-True] and the E2E sanity k25_thinking_fp4_blackwell config) lack owner/timeline metadata; update the waiver metadata to include the full NVBugs IDs (6236094, 6240561) with the assigned owner and an expected resolution ETA, replace short nvbug URLs with full bug links, and add a one-line follow-up action (owner + target date) so the waiver file and automated reporting can track remediation and re-enable the tests when fixed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 17: The waive entries for the two skipped tests
(accuracy/test_llm_api_autodeploy.py::TestModelRegistryAccuracy::test_autodeploy_from_registry[deepseek-ai_DeepSeek-R1-0528-True]
and the E2E sanity k25_thinking_fp4_blackwell config) lack owner/timeline
metadata; update the waiver metadata to include the full NVBugs IDs (6236094,
6240561) with the assigned owner and an expected resolution ETA, replace short
nvbug URLs with full bug links, and add a one-line follow-up action (owner +
target date) so the waiver file and automated reporting can track remediation
and re-enable the tests when fixed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 49c601fa-d49b-4eb7-b0aa-ceaaffaa7c54
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #51006 [ run ] triggered by Bot. Commit: |
|
PR_Github #51006 [ run ] completed with state
|
|
/bot skip --comment "Previous ci passed check test list" |
|
PR_Github #51147 [ skip ] triggered by Bot. Commit: |
|
PR_Github #51147 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @EmmaQiaoCh)
Target branch:
mainBug(s): 6236094, 6240561
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit